Merged
Conversation
phryneas
approved these changes
Jan 19, 2024
Comment on lines
+44
to
+49
| enter="ease-out duration-300" | ||
| enterFrom="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95" | ||
| enterTo="opacity-100 translate-y-0 sm:scale-100" | ||
| leave="ease-in duration-200" | ||
| leaveFrom="opacity-100 translate-y-0 sm:scale-100" | ||
| leaveTo="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95" |
Member
There was a problem hiding this comment.
Do these actually do something on a Fragment?
Member
Author
There was a problem hiding this comment.
I thought this too, but this is actually the recommendation straight from Headless UI: https://headlessui.com/react/dialog#transitions
phryneas
approved these changes
Jan 19, 2024
Member
phryneas
left a comment
phryneas
left a comment
There was a problem hiding this comment.
This looks very good already - my comments are mostly nitpicks.
Caveat: I only tested this in Chrome (Firefox didn't start for me today although it usually works), and I'm not a tailwind expert, so a lot of this is way over my level of expertise.
alessbell
approved these changes
Jan 23, 2024
Contributor
alessbell
left a comment
alessbell
left a comment
There was a problem hiding this comment.
Very excited to get this out there - so many nice UX upgrades, and tech debt removed at the same time 🎉🎉🎉
| root: true, | ||
| parser: "@typescript-eslint/parser", | ||
| plugins: ["@typescript-eslint", "testing-library", "jest-dom", "@emotion"], | ||
| plugins: ["@typescript-eslint", "testing-library", "jest-dom"], |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the dev tools to the new Apollo branding and color scheme. While working through this, I saw some opportunities for improvement in the layout and hierarchy so this contains some refactors of existing components to account for these changes.
Because I touched nearly every style in the app, this PR also full migrates to Tailwind and away from emotion for styling.
Closes #1094
Screenshots
Narrow screens
Light mode
