Avoid serializing the payload before sending it in devtools messages#1245
Merged
jerelmiller merged 3 commits intomainfrom Mar 7, 2024
Merged
Avoid serializing the payload before sending it in devtools messages#1245jerelmiller merged 3 commits intomainfrom
jerelmiller merged 3 commits intomainfrom
Conversation
jerelmiller
changed the title
jerelmiller
force-pushed
the
no-serialize-cache
branch
from
0dd01f9 to
d70ca1e
Compare
phryneas
approved these changes
Mar 7, 2024
Member
phryneas
left a comment
phryneas
left a comment
There was a problem hiding this comment.
That's so much better, LGTM! :)
Merged
This was referenced Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the JSON parsing/serialization of the queries/cache/mutations payload sent in the devtools messages when communicating with various parts of the devtools. This is mostly redundant since
window.postMessageuses the structured clone algorithm when sending data in message payloads.