Modify legacy registration mechanism#1375
Merged
jerelmiller merged 7 commits intomainfrom May 22, 2024
Merged
Conversation
jerelmiller
commented
May 17, 2024
| (preExisting as Array<ApolloClient<any>>).forEach(registerClient); | ||
| } | ||
|
|
||
| findClient(); |
Member
Author
There was a problem hiding this comment.
We no longer need this on initialization since we register the client immediately if its available, or registers it when the value is assigned from a legacy client.
#409 Bundle Size — 1.26MiB (~+0.01%).Warning Bundle contains 12 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch jerel/register-legacy Project dashboard |
8078164 to
0b39b19
Compare
jerelmiller
commented
May 19, 2024
| }; | ||
|
|
||
| window.addEventListener("load", () => { | ||
| if (hook.ApolloClient) { |
Member
Author
There was a problem hiding this comment.
This was almost never true, but with the changes in this PR, we don't need it anyways since we will register the client immediately if its available when this content script loads, or register it when the client is assigned on the window.
phryneas
approved these changes
May 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a precursor to some work I'm doing to make client discovery a bit less chaotic. Uses
Object.definePropertyfor the global property to monitor its setter and register the client with the devtools.