Automatically reconnect the ports when they disconnect#1390
Merged
jerelmiller merged 8 commits intomainfrom May 29, 2024
Merged
Automatically reconnect the ports when they disconnect#1390jerelmiller merged 8 commits intomainfrom
jerelmiller merged 8 commits intomainfrom
Conversation
#446 Bundle Size — 1.26MiB (+0.05%).Warning Bundle contains 12 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch jerel/auto-reconnect-port Project dashboard |
alessbell
approved these changes
May 29, 2024
Contributor
alessbell
left a comment
There was a problem hiding this comment.
Makes sense, especially given the 30 second idle timeout introduced in chrome 110 - hadn't seen that before. 🚀
Member
Author
|
@alessbell exactly! I stumbled upon it and it made a lot of sense why users might feel like it stops working after a time. Thanks for the review! |
Merged
jerelmiller
added a commit
that referenced
this pull request
May 30, 2024
This reverts commit 3b0f0ea.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a port disconnects, we will now try to automatically reconnect it to the background script. This should help in situations where the browser might disconnect the service worker due to inactivity.