Skip to content

Automatically reconnect the ports when they disconnect#1390

Merged
jerelmiller merged 8 commits intomainfrom
jerel/auto-reconnect-port
May 29, 2024
Merged

Automatically reconnect the ports when they disconnect#1390
jerelmiller merged 8 commits intomainfrom
jerel/auto-reconnect-port

Conversation

@jerelmiller
Copy link
Copy Markdown
Member

When a port disconnects, we will now try to automatically reconnect it to the background script. This should help in situations where the browser might disconnect the service worker due to inactivity.

@jerelmiller jerelmiller requested a review from a team as a code owner May 29, 2024 04:43
@relativeci
Copy link
Copy Markdown

relativeci bot commented May 29, 2024

#446 Bundle Size — 1.26MiB (+0.05%).

f8f311b(current) vs eacfbef main#442(baseline)

Warning

Bundle contains 12 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#446
     Baseline
#442
Regression  Initial JS 1.22MiB(+0.05%) 1.22MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 4.76% 3.37%
No change  Chunks 5 5
No change  Assets 12 12
No change  Modules 940 940
No change  Duplicate Modules 45 45
Change  Duplicate Code 3.88%(+1.57%) 3.82%
No change  Packages 160 160
No change  Duplicate Packages 9 9
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#446
     Baseline
#442
Regression  JS 1.22MiB (+0.05%) 1.22MiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 810B 810B
No change  Other 778B 778B

Bundle analysis reportBranch jerel/auto-reconnect-portProject dashboard

@jerelmiller jerelmiller requested review from alessbell and phryneas May 29, 2024 05:16
Copy link
Copy Markdown
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, especially given the 30 second idle timeout introduced in chrome 110 - hadn't seen that before. 🚀

@jerelmiller
Copy link
Copy Markdown
Member Author

@alessbell exactly! I stumbled upon it and it made a lot of sense why users might feel like it stops working after a time. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants