Revert "Push events from the client instead of polling for them"#1398
Merged
jerelmiller merged 2 commits intomainfrom May 30, 2024
Merged
Revert "Push events from the client instead of polling for them"#1398jerelmiller merged 2 commits intomainfrom
jerelmiller merged 2 commits intomainfrom
Conversation
This reverts commit eacfbef.
#466 Bundle Size — 1.26MiB (~+0.01%).Warning Bundle contains 12 duplicate packages – View duplicate packages Bundle metrics
|
| Current #466 |
Baseline #462 |
|
|---|---|---|
 Initial JS |
1.22MiB(~+0.01%) |
1.22MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
3.37% |
4.81% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
940 |
940 |
| Duplicate Modules |
45 |
45 |
| Duplicate Code |
3.82% |
3.82% |
| Packages |
160 |
160 |
| Duplicate Packages |
9 |
9 |
Bundle size by type 1 change 1 regression
| Current #466 |
Baseline #462 |
|
|---|---|---|
| JS |
1.22MiB (~+0.01%) |
1.22MiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
810B |
810B |
| Other |
778B |
778B |
Bundle analysis report Branch revert-1379-jerel/push-client-ev... Project dashboard
jerelmiller
force-pushed
the
revert-1379-jerel/push-client-events
branch
from
1401fae to
2a49ad5
Compare
jerelmiller
force-pushed
the
revert-1379-jerel/push-client-events
branch
from
2a49ad5 to
6880fa5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1379 to address perf issues reported in #1396