Skip to content

Add search input for queries and mutations tabs#1473

Merged
jerelmiller merged 8 commits intomainfrom
jerel/search-queries
Aug 19, 2024
Merged

Add search input for queries and mutations tabs#1473
jerelmiller merged 8 commits intomainfrom
jerel/search-queries

Conversation

@jerelmiller
Copy link
Copy Markdown
Member

Screenshot 2024-08-17 at 5 29 10 PM Screenshot 2024-08-17 at 5 29 18 PM Screenshot 2024-08-17 at 5 29 23 PM

@jerelmiller jerelmiller requested a review from a team as a code owner August 17, 2024 23:30
@relativeci
Copy link
Copy Markdown

relativeci bot commented Aug 17, 2024

#778 Bundle Size — 1.5MiB (+0.03%).

65ef982(current) vs 2df0b50 main#771(baseline)

Warning

Bundle contains 13 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#778
     Baseline
#771
Regression  Initial JS 1.46MiB(+0.03%) 1.46MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 92.81% 0%
No change  Chunks 5 5
No change  Assets 12 12
No change  Modules 1210 1210
No change  Duplicate Modules 45 45
No change  Duplicate Code 3.08% 3.08%
No change  Packages 182 182
No change  Duplicate Packages 10 10
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#778
     Baseline
#771
Regression  JS 1.46MiB (+0.03%) 1.46MiB
No change  IMG 35.85KiB 35.85KiB
No change  HTML 810B 810B
No change  Other 778B 778B

Bundle analysis reportBranch jerel/search-queriesProject dashboard


Generated by RelativeCIDocumentationReport issue

import { useActorEvent } from "../../hooks/useActorEvent";
import { SearchField } from "../SearchField";
import HighlightMatch from "../HighlightMatch";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to exist in this PR?

fetchPolicy: "cache-and-network",
pollInterval: 500,
});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a part of the other PR leaked over into this one ^^

Copy link
Copy Markdown
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it, but reads very straightforward - once you fix those fragments from the other PR and instead repeat the changes from the mutation page on the query page, you have my approval :)

@jerelmiller jerelmiller merged commit 1d622c4 into main Aug 19, 2024
@jerelmiller jerelmiller deleted the jerel/search-queries branch August 19, 2024 18:00
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants