Gracefully handle checkVersions network error#201
Merged
hwillson merged 4 commits intoapollographql:masterfrom May 31, 2019
Merged
Gracefully handle checkVersions network error#201hwillson merged 4 commits intoapollographql:masterfrom
hwillson merged 4 commits intoapollographql:masterfrom
Conversation
|
@mjlyons: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
woahitsraj
pushed a commit
to woahitsraj/apollo-client-devtools
that referenced
this pull request
Oct 15, 2019
* Gracefully handle checkVersions network error * Slight wording tweak * Changelog update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apollo Dev Tools is failing to initialize for me because my site's CSP settings block the checkVersions() request (to https://devtools.apollodata.com/graphql).
This change allows init() to proceed if the checkVersions network request fails.
I've verified that Apollo Dev Tools starts working with the patch by building the extension locally.