Do not save introspectionQuery results in the cache#273
Merged
jcreighton merged 1 commit intomasterfrom Jun 2, 2020
Merged
Conversation
jcreighton
force-pushed
the
fix-schema-inclusion
branch
2 times, most recently
from
970cc0a to
d1bce7c
Compare
jcreighton
force-pushed
the
fix-schema-inclusion
branch
from
d1bce7c to
e01b361
Compare
Closed
hwillson
approved these changes
Jun 2, 2020
Member
hwillson
left a comment
hwillson
left a comment
There was a problem hiding this comment.
Awesome @jcreighton, looks great - thanks very much!
This was referenced Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we did not pass the fetchPolicy through to the cache replica, which results in the introspection query being saved to the cache. These queries could be large enough to slow down or crash the devtools.
Fixes #271 and #231.