Fix the local state functionality in the dev tools#286
Fix the local state functionality in the dev tools#286jcreighton merged 1 commit intoapollographql:masterfrom
Conversation
apollographql#263 had removed passing the client-only schema from to the dev-tools
|
@micmro: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
@jcreighton @hwillson @benjamn do you have any feedback for this fix? This should fix #239 |
|
Is there an update on this? |
|
@micmro Thanks for this! I'll try to cut a new release soon. |
|
I have been unable to get your test case working with: devtools version 2.3.1 Only difference being that I use the typical provider setup:
Any suggestions? |
|
@fbegue this is probably because the changes from this PR have not been released yet. Sorry to bug you again @jcreighton, but is there any plan to cut a new release soon? |
|
@micmro Yes, working on that soon. |
|
omg.. so when??? |
|
Version 2.3.2 released on Firefox and Chrome! |
All the schemas on the Docs were disappeared after this update.. including schemas from apollo server.. |
|
@seunghwansohn Please be respectful in your responses. This project is maintained with a small team spread across projects . We are also in the middle of a complete rewrite of these tools to address issues in reliability and to make it easier to develop future improvements. You are more than welcome to open pull requests, if you'd like to contribute to the project. |
I see.. I think you rather develop a middleware loading on the apollo-client side. Through this, the developer can control the possibility of using dev tools on browsers. This dev tool is not reliable and risky now. You can refer to the Redux dev tools. Apollo is great, but not comparable to Redux only in terms of dev tool.. |


Since #263 the client-only schemas are not passed from the backend to the dev-tools anymore, which caused the dev-tools to not show any local-only schema information.
This PR is adding this back in, but using an immutable array as the previous version would append another
apolloClientSchemacopy toschemaseach timenextwas called.Test setup:
Before this change (expected

testClientOnlyFiledto be in Query and Explorer panel):After this change (

testClientOnlyFiledis in Query and Explorer panel):