Use Rollup to build also as ESM #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdonrd
force-pushed
the
rollup-es-modules
branch
from
c290d2e to
b4ba6a9
Compare
abdonrd
force-pushed
the
rollup-es-modules
branch
from
15caf00 to
a69054b
Compare
abdonrd
force-pushed
the
rollup-es-modules
branch
from
a69054b to
40046ce
Compare
|
Very interested in this PR too! |
|
Any updates about ES6 module? |
PowerKiKi
added a commit
to PowerKiKi/graphql-tag
that referenced
this pull request
Nov 6, 2020
This upgrade all dev dependencies in order to implement ES6 exports in order to solve apollographql#303. This also remove yarn.lock entirely because this package is meant to work with npm only as can be seen from the mention of npm command in package.json. Fixes apollographql#303 Closes apollographql#272 Closes apollographql#273
Contributor
|
Ideally, this should be closed in favor of #325. |
abdonrd
force-pushed
the
rollup-es-modules
branch
from
40046ce to
77080dc
Compare
Contributor
|
I only meant to help merge a apparently staled PR, but I didn't realize this PR was still active. So of course, feel free to merge either of them. It really does not matter to me, as long as we can release those improvements to the community. |
Contributor
Author
|
From time to time I rebase the PR... |
Contributor
Author
|
@PowerKiKi @benjamn new year, updated again! |
Member
benjamn
pushed a commit
to PowerKiKi/graphql-tag
that referenced
this pull request
Jan 29, 2021
This upgrade all dev dependencies in order to implement ES6 exports in order to solve apollographql#303. This also remove yarn.lock entirely because this package is meant to work with npm only as can be seen from the mention of npm command in package.json. Fixes apollographql#303 Closes apollographql#272 Closes apollographql#273
This was referenced Mar 11, 2021
This was referenced Mar 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #229
Based on #272.