Skip to content

Add timeout to init_process_group in entrypoint #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apoorvkh opened this issue Jul 16, 2024 · 4 comments · Fixed by #44
Closed

Add timeout to init_process_group in entrypoint #43

apoorvkh opened this issue Jul 16, 2024 · 4 comments · Fixed by #44

Comments

@apoorvkh
Copy link
Owner

Question: what's the longest a distributed operation should reasonably take?
How long would it take to "all-gather" a large amount of memory (like 80 GB)?

Let's set a smaller default timeout... maybe 180 seconds?
And then we can pass an argument to override this.

dist.init_process_group(
backend=backend, world_size=worker_args.world_size, rank=worker_args.rank, store=store
)

@apoorvkh
Copy link
Owner Author

@apoorvkh
Copy link
Owner Author

I guess they added monitored_barrier but it only works for GLOO.

https://pytorch.org/docs/stable/distributed.html#torch.distributed.monitored_barrier

I still think we can reduce this default, but allow users to override if desired.

@pmcurtin
Copy link
Collaborator

pytorch/pytorch#13056 (comment)

Oh yeah, that'd be great. I was thinking barriers might be an issue. I think this is a PyTorch issue really.

I still think we can reduce this default, but allow users to override if desired.

Yeah that sounds reasonable.

@apoorvkh
Copy link
Owner Author

Let's actually keep the same default but allow users to override :)

@apoorvkh apoorvkh linked a pull request Jul 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants