Skip to content

add pg_timeout flag #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2024
Merged

add pg_timeout flag #44

merged 2 commits into from
Jul 18, 2024

Conversation

pmcurtin
Copy link
Collaborator

@pmcurtin pmcurtin commented Jul 17, 2024 •
edited
Loading

solving #43

@apoorvkh apoorvkh self-requested a review July 17, 2024 17:59
apoorvkh
apoorvkh requested changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@apoorvkh apoorvkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Except can we just call it timeout instead of pg_timeout? Especially in launch(). Thanks!

@apoorvkh apoorvkh merged commit 1961e45 into main Jul 18, 2024
4 checks passed
@apoorvkh apoorvkh deleted the pg-timeout branch July 18, 2024 16:47
@apoorvkh apoorvkh linked an issue Jul 22, 2024 that may be closed by this pull request
Add timeout to init_process_group in entrypoint #43
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvkh apoorvkh apoorvkh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timeout to init_process_group in entrypoint
2 participants
@pmcurtin @apoorvkh