Skip to content

submitit fix #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2024
Merged

submitit fix #36

merged 3 commits into from
Jul 11, 2024

Conversation

pmcurtin
Copy link
Collaborator

No description provided.

@pmcurtin
Copy link
Collaborator Author

Seemed to work for me, just try out on your side and then we can merge!

@pmcurtin pmcurtin requested a review from apoorvkh July 10, 2024 21:08
@apoorvkh
Copy link
Owner

Okay great, I think this works when the script is successful!

However, it does not seem to work when the script raises an error :(

E.g. simply set this in your submitit test script.

def main():
    raise RuntimeError

Would you adjust for this case? Thanks!

But also, I think we designed our scripts with the assumption that child processes die with their parents and we might need to make more changes if that is not the case?

@apoorvkh
Copy link
Owner

I think we might also be interested in making daemon processes (which die with the parent process):

https://stackoverflow.com/a/34353290

@pmcurtin
Copy link
Collaborator Author

Yeah we could daemonize the printing process, not sure if it can easily be done for the processes spawned by PyTorch, however.

@apoorvkh
Copy link
Owner

Looks like this works! I also tested it on two nodes with 1 GPU each.

@apoorvkh apoorvkh merged commit 8b6dab2 into main Jul 11, 2024
3 checks passed
@apoorvkh apoorvkh deleted the submitit branch July 11, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants