Skip to content

Change launch to Launcher dataclass #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 15, 2024
Merged

Change launch to Launcher dataclass #40

merged 8 commits into from
Jul 15, 2024

Conversation

apoorvkh
Copy link
Owner

No description provided.

@pmcurtin
Copy link
Collaborator

CI test will fail because it uses torchrunx.launch

@apoorvkh
Copy link
Owner Author

todo: add alias for launch() with pytest to ensure arguments are the same as Launcher().run() and do something clever to copy the argument docstrings

@apoorvkh
Copy link
Owner Author

we can probably still feature trx.launch() in the README as the easy way to use this ...
but in the "advanced usage", we can mention the Launcher class for CLI purposes

@apoorvkh apoorvkh marked this pull request as ready for review July 14, 2024 06:26
@apoorvkh apoorvkh self-assigned this Jul 14, 2024
@apoorvkh apoorvkh requested a review from pmcurtin July 14, 2024 06:26
pmcurtin
pmcurtin approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@pmcurtin pmcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pmcurtin pmcurtin merged commit 4cbc660 into main Jul 15, 2024
3 checks passed
@pmcurtin pmcurtin deleted the argument-class branch July 15, 2024 16:02
apoorvkh
apoorvkh commented Jul 15, 2024
View reviewed changes
src/torchrunx/slurm.py
@@ -2,7 +2,7 @@
import subprocess


def slurm_hosts() -> list[str]:
def slurm_hosts() -> "list[str]":
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pyright was complaining about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcurtin pmcurtin pmcurtin approved these changes

Assignees

@apoorvkh apoorvkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apoorvkh @pmcurtin