Skip to content

examples to tests #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 17, 2024
Merged

examples to tests #45

merged 16 commits into from
Aug 17, 2024

Conversation

pmcurtin
Copy link
Collaborator

@pmcurtin pmcurtin commented Jul 18, 2024

#42

@pmcurtin
Copy link
Collaborator Author

I'll be adding more tests to cover error cases.

@pmcurtin pmcurtin linked an issue Jul 24, 2024 that may be closed by this pull request
@pmcurtin pmcurtin requested a review from apoorvkh July 25, 2024 16:28
@pmcurtin
Copy link
Collaborator Author

Actually let me resolve the conflict before reviewing.

@pmcurtin
Copy link
Collaborator Author

I have to fix this newer test I added. It works locally but not as an action somehow. It is a sketchy test and I'm reconsidering whether it's even useful (don't worry about it).

@apoorvkh
Copy link
Owner

I think we use submitit and transformers for extra testing. Should make a pixi environment for extras.

@pmcurtin
Copy link
Collaborator Author

@apoorvkh Alright, this is finished for now. Probably be good to flush out a few more CI tests eventually, but I'd like to merge this so we can finish up and go for a beta release.

Copy link
Owner

@apoorvkh apoorvkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoorvkh apoorvkh merged commit 4022811 into main Aug 17, 2024
29 checks passed
@apoorvkh apoorvkh deleted the testing branch August 17, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests
2 participants