-
Notifications
You must be signed in to change notification settings - Fork 1
examples to tests #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll be adding more tests to cover error cases. |
Actually let me resolve the conflict before reviewing. |
I have to fix this newer test I added. It works locally but not as an action somehow. It is a sketchy test and I'm reconsidering whether it's even useful (don't worry about it). |
I think we use |
@apoorvkh Alright, this is finished for now. Probably be good to flush out a few more CI tests eventually, but I'd like to merge this so we can finish up and go for a beta release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#42