Skip to content

automatic function #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 12, 2024
Merged

automatic function #52

merged 10 commits into from
Aug 12, 2024

Conversation

pmcurtin
Copy link
Collaborator

@pmcurtin pmcurtin commented Jul 24, 2024

#47

@pmcurtin pmcurtin linked an issue Jul 24, 2024 that may be closed by this pull request
@pmcurtin
Copy link
Collaborator Author

@apoorvkh Was this kind of what you were thinking of? The automatic function returns the hostnames and workers_per_host arguments for launch... The user would have to call hosts, workers = automatic() and then manually pass the arguments to launch. We could just add a flag to launch that causes it to call automatic internally and use its output rather than the hostnames and workers that the user passes.

We can also rename automatic to something more descriptive like automatic_topology (idk).

@apoorvkh
Copy link
Owner

Yeah, close to what I was suggesting! See comments.

And I agree, we should add flags to launch: e.g. launch(..., auto=True, hostnames=None, workers=None) where this would infer if hostnames is None: hostnames = auto_hosts() etc.

Copy link
Owner

@apoorvkh apoorvkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- feel free to merge once tests pass

@apoorvkh apoorvkh merged commit 4f065cd into main Aug 12, 2024
4 checks passed
@apoorvkh apoorvkh deleted the automatic branch August 12, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No hostnames in launch ?
2 participants