fix: only enable rosetta by default when installed#1188
fix: only enable rosetta by default when installed#1188manojmahapatra wants to merge 1 commit intoapple:mainfrom
Conversation
|
Hi @manojmahapatra, please setup signed commits. See: https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests |
|
Yes, it was missing on my new MBP, I've set it up correctly now. |
6b9373f to
d7b9711
Compare
|
@jglogan when you've time, can you please review this? |
@manojmahapatra Sorry I have been swamped and will continue to be through next week. I did get a chance to look at a cluster of PRs tonight. This looks perfectly fine. We've still got a few lingering container lifecycle bugs that hit us nondeterministically in CI, so I'm trying to get a build working and then will approve/merge. Apologies for the delay! |
|
No worries, and no rush btw. I just wanted to bubble this up. Thank you! |
Type of Change
Motivation and Context
Addressing #1136
On fresh installs,
build.rosettadefaults totrue, which makes the builder VM request rosetta even when it isn’t installed. That looks like hits a potentialVirtualization.frameworkinstall‑prompt bug and fails the build unexpectedly. This change keeps the existing auto install behavior for explicit opt‑in while preventing the default path from enabling Rosetta unless it’s already installed.Testing