Adds --publish flag for forwarding traffic to container ports.#352
Merged
jglogan merged 2 commits intoapple:mainfrom Jul 23, 2025
Merged
Adds --publish flag for forwarding traffic to container ports.#352jglogan merged 2 commits intoapple:mainfrom
--publish flag for forwarding traffic to container ports.#352jglogan merged 2 commits intoapple:mainfrom
Conversation
jglogan
force-pushed
the
users/jglogan/publish-port
branch
2 times, most recently
from
cf8db4a to
da1d7ee
Compare
Contributor
Author
|
Closes #97 |
jglogan
force-pushed
the
users/jglogan/publish-port
branch
2 times, most recently
from
da1d7ee to
43c1e2b
Compare
jglogan
force-pushed
the
users/jglogan/publish-port
branch
from
43c1e2b to
2243ddd
Compare
| self.interfaceStrategy = interfaceStrategy | ||
| self.log = log | ||
| self.monitor = ExitMonitor(log: log) | ||
| self.eventLoopGroup = MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount) |
Contributor
There was a problem hiding this comment.
Should we be calling shutdownGracefully anywhere for this?
Contributor
Author
There was a problem hiding this comment.
probably should let the caller allocate and manage the lifecycle
katiewasnothere
approved these changes
Jul 22, 2025
jglogan
force-pushed
the
users/jglogan/publish-port
branch
from
2243ddd to
27bbe63
Compare
jglogan
added a commit
to jglogan/container
that referenced
this pull request
Jul 23, 2025
- Forgot to commit the changes to gracefully shut down the event loop group used by the port forwards.
jglogan
added a commit
that referenced
this pull request
Jul 23, 2025
2 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.