Skip to content

Add Fortnite and Twinmotion to shared credentials#867

Merged
rmondello merged 1 commit intoapple:mainfrom
breakgimme:epic
Mar 5, 2025
Merged

Add Fortnite and Twinmotion to shared credentials#867
rmondello merged 1 commit intoapple:mainfrom
breakgimme:epic

Conversation

@breakgimme
Copy link
Contributor

@breakgimme breakgimme commented Jan 29, 2025

Overall Checklist

for shared-credentials.json

  • There's evidence the domains are currently related (SSL certificates, DNS entries, valid links between sites, legal documents etc.)
  • If using shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use a shared association from google.co.il to google.com, because google.co.il redirects to accounts.google.com for sign in.)
  • If using from and to, the new group, the from domain(s) redirect to the to domain to log in.

Evidence:

  • there already exists an identical case for unrealengine.com
  • the websites link to each other via the menu in the top left corner
  • logging in to any of the shared websites makes sso requests to the others
Zrzut ekranu 2025-01-29 o 02 39 00

@breakgimme breakgimme requested a review from rmondello March 5, 2025 00:26
@breakgimme
Copy link
Contributor Author

sorry for the redundant review request, was a miss click

@rmondello rmondello merged commit cfcd861 into apple:main Mar 5, 2025
5 checks passed
@rmondello
Copy link
Contributor

np @breakgimme! thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants