shared-credentials: Add auth.wikimedia.org to Wikimedia set#868
Merged
rmondello merged 1 commit intoapple:mainfrom Jan 30, 2025
Merged
shared-credentials: Add auth.wikimedia.org to Wikimedia set#868rmondello merged 1 commit intoapple:mainfrom
rmondello merged 1 commit intoapple:mainfrom
Conversation
Contributor
|
Hi @Krinkle! Thank you for this thoughtful contribution with lots of cited supporting evidence. Accommodating a change ahead of time isn’t something we’ve done before, but I’m more than happy to do it in this case. |
rmondello
approved these changes
Jan 30, 2025
Contributor
Author
|
@rmondello Thanks. Yeah, it's an atypical addition because it's not really adding a new site (i.e. a site with its own user signup and where community overlap to other sites might be minimal at first, so non-urgent). Anyone who's ever saved a password for Wikipedia will lose auto-fill unless the new domain is associated with previous domains. |
Contributor
|
@Krinkle Atypical, but valuable! |
rmondello
pushed a commit
to rmondello/password-manager-resources
that referenced
this pull request
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall Checklist
for shared-credentials.json
shared, the new group serves login pages on each of the included domains, and those login pages accept accounts from the others. (For example, we wouldn't use asharedassociation fromgoogle.co.iltogoogle.com, becausegoogle.co.ilredirects toaccounts.google.comfor sign in.)Hi,
I'm an engineer on the MediaWiki Engineering team at Wikimedia Foundation. Over the next few months, we'll be moving logins from being local to each of ~900 wikis over ~10 top-level domains (with credentials shared behind the scenes) to instead happen centrally on the new
auth.wikimedia.orgdomain.This can be tested today on https://test.wikipedia.org/ where "Log in" directs you to https://auth.wikimedia.org/testwiki/wiki/Special:UserLogin. Compare this to the status quo on domains like en.wikipedia.org, wikidata.org, and ja.wikivoyage.org where login happens on the same domain.
Issue tracker: https://phabricator.wikimedia.org/T384844