Skip to content

Prevent implementation-only import build warnings on older Swift #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

rgoldberg
Copy link
Contributor

Prevent implementation-only import build warnings on older Swift.

Resolve #719

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000
Copy link
Member

@swift-ci Please test macOS platform

@natecook1000 natecook1000 merged commit 23d8d3a into apple:main Feb 12, 2025
21 checks passed
@rauhul
Copy link
Contributor

rauhul commented Feb 12, 2025

Can we enable werror to avoid leaking warnings into the build?

@rgoldberg rgoldberg deleted the 719-import-warnings branch February 12, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"inconsistently imported as implementation-only" build warning for Swift 5.7.x.
3 participants