Enable full test suite for Wasm with main snapshots#548
Draft
MaxDesiatov wants to merge 2 commits intomainfrom
Draft
Enable full test suite for Wasm with main snapshots#548MaxDesiatov wants to merge 2 commits intomainfrom
main snapshots#548MaxDesiatov wants to merge 2 commits intomainfrom
Conversation
We should use `swift test` as `wasm_sdk_build_command` in `pull_request.yml` to actually run the tests. Previously only the library itself was built, but not tested.
main snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should use
swift testaswasm_sdk_build_commandinpull_request.ymlto actually run the tests. Previously only the library itself was built but not tested, because released versions of Swift that support Wasm didn't have workingswift testwhen using non-embedded Swift SDK for Wasm.Checklist