Skip to content

Add support for AES CFB mode in _CryptoExtras #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

simonjbeaumont
Copy link
Contributor

@simonjbeaumont simonjbeaumont commented Aug 29, 2024

Motivation

We have AES support in _CryptoExtras for CBC, CTR, and GCM-SIV modes; but we do not have support for CFB.

Modifications

  • Add support for AES-CFB, backed by BoringSSL, with the same shape of API as we provide for AES CTR.
  • Copy RFCVector decoder from Crypto tests to CryptoExtrasTests.
  • Add test vectors from NIST.

Result

New API added to support AES-CFB.

@simonjbeaumont simonjbeaumont marked this pull request as ready for review August 29, 2024 15:47
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@simonjbeaumont
Copy link
Contributor Author

Thanks @Lukasa I just push an update that renamed Nonce to IV, throughout. Otherwise no changes since your review. I'll leave it with you to merge whenever it's a good time.

@Lukasa Lukasa merged commit 9f95b4d into apple:main Sep 3, 2024
9 checks passed
@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants