[docc] Fail soundness on docc warnings (bad links), fix a few warnings#1027
Merged
ktoso merged 17 commits intoapple:mainfrom Jul 28, 2022
Merged
[docc] Fail soundness on docc warnings (bad links), fix a few warnings#1027ktoso merged 17 commits intoapple:mainfrom
ktoso merged 17 commits intoapple:mainfrom
Conversation
2 tasks
Member
Author
|
Also resolves #1017 |
Member
Author
|
@swift-server-bot test this please |
Member
Author
|
@swift-server-bot test this please |
ktoso
commented
Jul 26, 2022
| /// located on has been declared ``Cluster/MemberStatus/down``. | ||
| /// | ||
| /// - Parameter id: the ID of the now terminated actor | ||
| func terminated(actor id: ActorID) async throws // FIXME(distributed): Should not need to be throwing: https://github.com/apple/swift/pull/59397 |
Member
Author
There was a problem hiding this comment.
hooray! compiler no longer crashes and we can remove this workaround everywhere 🎉 🎉 🎉
ktoso
commented
Jul 26, 2022
Sources/DistributedActors/DistributedActors.docc/Receptionist.md
Outdated
Show resolved
Hide resolved
ktoso
commented
Jul 26, 2022
ktoso
commented
Jul 26, 2022
| struct WeakActorDictionary { | ||
| var underlying: [ClusterSystem.ActorID: WeakDistributedActorContainer] = [:] | ||
| /// A dictionary which only weakly retains the | ||
| public struct WeakActorDictionary<Act: DistributedActor>: ExpressibleByDictionaryLiteral |
Member
Author
There was a problem hiding this comment.
TODO: incomplete; need to make them a bit nicer API so we can use them in examples ourselfes as well
Member
Author
|
Meh sorry this is incomplete I just realized, I'll get through it tomorrow. |
Member
yim-lee
reviewed
Jul 26, 2022
Sources/DistributedActors/DistributedActors.docc/Receptionist.md
Outdated
Show resolved
Hide resolved
ktoso
force-pushed
the
wip-cleanups
branch
4 times, most recently
from
845a88e to
cd2e53d
Compare
musttail call swifttailcc void %4(%swift.context* swiftasync %1, %swift.error* %2), !dbg !1538 in function $s17DistributedActors10WorkerPoolCyxGAA14LifecycleWatchA2aEP10terminated5actoryAA13ClusterSystemC7ActorIDV_tYaFTW.0.61 <unknown>:0: error: fatal error encountered during compilation; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project <unknown>:0: note: Broken function found, compilation aborted!
Co-authored-by: Yim Lee <yim_lee@apple.com>
Member
Author
|
Meh, needed a rebase now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Commentagain to enable it; (fishy docs is what does our "does this code compile" checks)