Changed workflows from apple/swift-nio to swiftlang/github-workflows#1226
Closed
akbashev wants to merge 2 commits intoapple:mainfrom
Closed
Changed workflows from apple/swift-nio to swiftlang/github-workflows#1226akbashev wants to merge 2 commits intoapple:mainfrom
akbashev wants to merge 2 commits intoapple:mainfrom
Conversation
Disable macos for now name fix Disabled cxx will still use pull_request_semver_label_checker from swift-nio Let's disable integration tests for now updated tests jobs commands Should be different format Return thread back let's try to enable integration tests no newline let's try with macos let's try like that fix let's try to enable should be this version for now enabled back macos checks
Contributor
Author
akbashev
commented
Oct 8, 2025
| self.system = nil | ||
| self.testKit = nil | ||
| try! self.elg.syncShutdownGracefully() | ||
| try! await self.elg.shutdownGracefully() |
Contributor
Author
There was a problem hiding this comment.
Was testing something internal, but guess won't harm to update.
Member
|
We could just stick to 6.2 Linux and keep tests stable during the rewrite attempt |
Member
This is not true. The workflows in NIO are a lot more powerful and we don't intend to move our repos over at this time. |
FranzBusch
requested changes
Oct 8, 2025
Member
FranzBusch
left a comment
FranzBusch
left a comment
There was a problem hiding this comment.
Blocking this PR for now so it doesn't get merged
Member
|
Let's leave as is, we don't really need the cxx ones it just adds noise nowadays, how about we disable just those @akbashev |
Contributor
Author
|
@ktoso yeah, let's do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As all swift community repositories slowly moving to github workflows from swiftlang, and not to rely on swift-nio — it makes sense to move this repository too.
Note that semver label check still uses swift-nio workflow, and this PR also removes cxx tests.
Fixes #1218.