Merged
Conversation
ktoso
force-pushed
the
wip-safer-lifecycle-watch
branch
from
9f4885c to
913d060
Compare
Member
Author
|
No joy, we have a crash on the nightly but not in betas on macOS -- investigating. |
ktoso
force-pushed
the
wip-safer-lifecycle-watch
branch
2 times, most recently
from
ff9128a to
e2f3041
Compare
ktoso
force-pushed
the
wip-safer-lifecycle-watch
branch
from
1922d83 to
0b024da
Compare
ktoso
force-pushed
the
wip-safer-lifecycle-watch
branch
from
0b024da to
5955887
Compare
ktoso
commented
Jun 14, 2022
| extension LifecycleWatchContainer { | ||
| /// Performed by the sending side of "watch", therefore the `watcher` should equal `context.myself` | ||
| public func termination<Watchee>( | ||
| of watchee: Watchee, |
Member
Author
There was a problem hiding this comment.
Current dev branches REALLY don't like the generic here (regardless of the self capture things below)
ktoso
commented
Jun 14, 2022
| .tvOS(.v16), | ||
| .watchOS(.v9), | ||
| ] | ||
| #endif |
Member
Author
There was a problem hiding this comment.
Workaround for 5.7 docker images being pre-wwdc.
Member
Author
|
Going to merge this to make progress with the other "parked" PRs, but review is welcome @yim-lee ! |
yim-lee
reviewed
Jun 14, 2022
| } | ||
|
|
||
| private func onWorkerTerminated(id: Worker.ID) { | ||
| public distributed func terminated(actor id: Worker.ID) { |
Member
There was a problem hiding this comment.
This new API works out rather nicely I think (e.g., even less code duplication).
Member
Author
There was a problem hiding this comment.
Yeah, it's pretty nice actually:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A safer shape of the lifecycle API
Resolves #884