!context store lifecycle in DistributedActorContext; internal only#976
Merged
ktoso merged 7 commits intoapple:mainfrom Jun 29, 2022
Merged
Conversation
Member
Author
|
(silly bugs remain, but will fix) |
Member
Author
|
@swift-server-bot test this please |
ktoso
force-pushed
the
wip-remove-lifecycle-storage-from-system
branch
from
486985c to
6c9ab67
Compare
ktoso
force-pushed
the
wip-remove-lifecycle-storage-from-system
branch
from
6c9ab67 to
6b9bc96
Compare
Member
Author
|
@swift-server-bot test this please |
Member
Author
|
@swift-server-bot test this please Not sure if this is caused by this PR, trying again to check |
Member
Author
|
signal intercepting likes to flaky fail, but we're removing this anyway 🤔 |
Member
Author
|
@swift-server-bot test this please |
Member
Author
|
Flaky failure #970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #926
By moving state associated with concrete actors, we decrease lock contention and allow each actor to store the additional state used for lifecycle API.
We do not expose the distributed actor context as user API, and it will only be ever accessed by the actor system at actor init and actor deinit and the actor itself via the LifecycleWatch protocol