Add ability to watch distributed actor with TestProbe#991
Merged
ktoso merged 8 commits intoapple:mainfrom Jul 8, 2022
Merged
Conversation
ktoso
reviewed
Jul 8, 2022
ktoso
reviewed
Jul 8, 2022
ktoso
reviewed
Jul 8, 2022
ktoso
reviewed
Jul 8, 2022
ktoso
reviewed
Jul 8, 2022
Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
ktoso
approved these changes
Jul 8, 2022
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
LGTM! We simplified the timeout a bit too :)
Member
Author
|
Test failures: #945, #992 (new) @swift-server-bot test this please |
Member
|
Fixed the timeout task issue: 19bbec0 Was a bit brain bending but I guess makes sense... the cancellation could have executed synchronously and trigger the cancellation to complete the |
Member
|
@swift-server-bot test this please |
Member
|
Ok I really need to stabilize |
Member
|
otherwise all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #990