Silence OpLogDistributedReceptionist.sendAckOps timeout logs#996
Merged
ktoso merged 3 commits intoapple:mainfrom Jul 9, 2022
Merged
Silence OpLogDistributedReceptionist.sendAckOps timeout logs#996ktoso merged 3 commits intoapple:mainfrom
ktoso merged 3 commits intoapple:mainfrom
Conversation
Member
|
Ah this looks right, thank you -- would you mind merging this |
Contributor
Author
|
@ktoso Done! Should I also make the comment more generic? |
Member
|
Hm yeah, just that timeouts are an expected thing here really |
Contributor
Author
|
Ok, I modified it a bit. |
ktoso
approved these changes
Jul 9, 2022
Member
|
LGTM thank you! |
Member
|
We have one very flaky test since recently, I'll get to it soon. Tests good other than that one |
Contributor
Author
|
Oops it looks like I missed something and the error was actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't really easily reproduce the specific error that caused the logging, but as far as I can tell this is where it came from and I also didn't see this message anymore in my logs.
I was wondering if I should just drop it entirely or maybe still log it under the trace level for instance?