Introduce CI #97
Merged
Introduce CI #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Apr 7, 2025
| @@ -0,0 +1,18 @@ | |||
| name: PR label | |||
There was a problem hiding this comment.
We don't need this: this repo is unversioned and doesn't get released.
| @@ -1,3 +1,18 @@ | |||
| //===----------------------------------------------------------------------===// | |||
There was a problem hiding this comment.
There's already a license header in this file
dev/build_all.sh
Outdated
| error() { printf -- "** ERROR: %s\n" "$*" >&2; } | ||
| fatal() { error "$@"; exit 1; } | ||
|
|
||
| default_package_directories="TLSify UniversalBootstrapDemo backpressure-file-io-channel http-responsiveness-server connect-proxy http2-client http2-server json-rpc nio-launchd" |
There was a problem hiding this comment.
We have a similar setup in gRPC where we want to build all examples, rather than listing them all we look for directories containing Package.swift: https://github.com/grpc/grpc-swift/blob/edb1ec6a5f5e3d3bd1f1a9353b18edc170df4689/dev/build-examples.sh#L25-L26
Might be worth doing similar here.
dev/build_all.sh
Outdated
Comment on lines
47
to
53
| if [ -n "$xcode_build_enabled" ]; then | ||
| for directory in $project_directories; do | ||
| log "Building: $directory" | ||
| cd "$directory" || fatal "Could not cd to ${directory}." | ||
| $xcode_build_command | ||
| cd .. || fatal "Could not cd to parent." | ||
| done |
There was a problem hiding this comment.
nit: indentation is weird here
glbrntt
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add CI which builds (most of) the examples. We can use this to monitor hitting strict concurrency targets as the following PRs from #96 are merged
Modifications
NIOSMTPbackpressure-file-iowhich is built around deprecated API and so has unrelated warningsResult