Use unchecked math in encodeInteger#328
Merged
Merged
Conversation
Motivation Checked math is great when you aren't sure what the constraints are, but in some places we happen to know that all the arithmetic operations occur in a defined domain and range. In those cases, we can improve the codegen by adopting unchecked math. Modifications Widely adopt unchecked math in encodeInteger. Result Better codegen for encodeInteger.
glbrntt
approved these changes
Feb 23, 2022
fabianfett
approved these changes
Feb 23, 2022
Contributor
Author
|
@swift-nio-bot test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Checked math is great when you aren't sure what the constraints are, but
in some places we happen to know that all the arithmetic operations
occur in a defined domain and range. In those cases, we can improve the
codegen by adopting unchecked math.
Modifications
Widely adopt unchecked math in encodeInteger.
Result
Better codegen for encodeInteger.