Allow channel writes to be just sending and not Sendable#3384
Draft
fabianfett wants to merge 2 commits intoapple:mainfrom
Draft
Allow channel writes to be just sending and not Sendable#3384fabianfett wants to merge 2 commits intoapple:mainfrom
fabianfett wants to merge 2 commits intoapple:mainfrom
Conversation
Member
Author
|
The API breaker check complains, but the existing Channels compile without any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PostgresNIO there is a type that is not Sendable but that is used when writing to a Channel. Channel write does not require
Sendable.sendingis sufficient.Even though the protocol is extended here, we apparently don't need to add further implementations.