Open
Conversation
In order to enable uses of `nonisolated(nonsending)` in #3378 without adding this sequence of characters everywhere, this pr enables the upcoming feature `NonIsolatedNonSendableByDefault `
FranzBusch
approved these changes
Nov 13, 2025
Member
|
FWIW, in our internal code bases, enabling NonisolatedNonsendingByDefault has caused a lot of trouble and incompatibilities. So at this point in time, I would only recommend merging this if has been tested on a variety of Xcode & Swift OSS compiler versions with a lot of real-world software. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to enable uses of
nonisolated(nonsending)in #3378 without adding this sequence of characters everywhere, this pr enables the upcoming featureNonIsolatedNonSendableByDefaultMost of the changes are about adding
next(isolation:)calls, where non existed before and wiring through the isolation level to the underlying next call. To please the compiler, I've also made explicit thatnext()runs on the concurrent executor, by slapping@concurrenton it.Interestingly
nonisolated(nonsending)is not applied to nested function definitions. I applied those manually.