Skip to content

Re-enable --explicit-target-dependency-import-check once swift-syntax is fixed #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
czechboy0 opened this issue Oct 16, 2023 · 0 comments · Fixed by #347
Closed

Re-enable --explicit-target-dependency-import-check once swift-syntax is fixed #332

czechboy0 opened this issue Oct 16, 2023 · 0 comments · Fixed by #347
Assignees
@czechboy0
Labels
kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue.
Milestone
1.0

Comments

@czechboy0
Copy link
Contributor

Re-enable --explicit-target-dependency-import-check once swift-syntax is fixed.

We had to disable it in #331, filed on swift-syntax as swiftlang/swift-syntax#2287.
@czechboy0 czechboy0 added kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue. labels Oct 16, 2023
@czechboy0 czechboy0 added this to the 1.0 milestone Oct 16, 2023
@czechboy0 czechboy0 mentioned this issue Oct 16, 2023
Merged
@czechboy0 czechboy0 self-assigned this Oct 25, 2023
@czechboy0 czechboy0 mentioned this issue Oct 25, 2023
Merged
czechboy0 added a commit that referenced this issue Oct 26, 2023
@czechboy0
Enable more CI warnings (#347)
4355b3a 
Enable more CI warnings

### Motivation

Fixes #332 and re-enables warnings as errors as we don't have deprecation warnings in our tests anymore.

### Modifications

Enabled a few previously disabled warnings/errors.

### Result

Stricter CI.

### Test Plan

The CI on this PR.


Reviewed by: PeterAdams-A

Builds:
     ✔︎ pull request validation (5.10) - Build finished. 
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (compatibility test) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (integration test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czechboy0 czechboy0

Labels
kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Enable more CI warnings czechboy0/swift-openapi-generator
1 participant
@czechboy0