Python console minor issues#1513
Merged
dictoon merged 6 commits intoappleseedhq:masterfrom Jul 9, 2017
Merged
Conversation
…when there is no selection
est77
requested changes
Jul 8, 2017
| namespace appleseed { | ||
| namespace studio { | ||
|
|
||
| class FontSizeChangeable |
Member
There was a problem hiding this comment.
Maybe we could call this class ZoomablePlainTextEdit?
|
|
||
| void PythonConsoleWidget::slot_change_exec_selection_button_state() | ||
| { | ||
| bool is_enabled = m_input->textCursor().selection().isEmpty(); |
dictoon
reviewed
Jul 8, 2017
| insert_spaces(4); | ||
| else | ||
| { | ||
| if (event->key() == Qt::Key_Return || event->key() == Qt::Key_Enter) |
Member
There was a problem hiding this comment.
Did you find the root cause of the problem causing Shift+Enter inserting "lines within the line"?
Contributor
Author
There was a problem hiding this comment.
I think shift+enter insert something like soft return in Microsoft Word (https://www.computerhope.com/jargon/s/softretu.htm) but I can't find anything in docs
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Yes, I've read it too. It's similar to how I solved it but my solution is simpler. I just unset shift modifier in case shift+enter is pressed
Member
|
Very nice work! |
glebmish
force-pushed
the
python-console-minor-issues
branch
from
dcc3ad7 to
84451e6
Compare
dictoon
reviewed
Jul 9, 2017
| // THE SOFTWARE. | ||
| // | ||
|
|
||
| #ifndef APPLESEED_STUDIO_MAINWINDOW_PYTHONCONSOLE_FONTSIZECHANGEABLE_H |
glebmish
force-pushed
the
python-console-minor-issues
branch
from
84451e6 to
02d32f9
Compare
dictoon
approved these changes
Jul 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved issues #1474, #1478, #1500 and some other that were not tracked