Tile highlights are now colored#2785
Merged
dictoon merged 5 commits intoappleseedhq:masterfrom Mar 7, 2020
Merged
Conversation
Choose one color per thread (see https://www.shadertoy.com/view/wlKXDm).
oktomus
requested changes
Mar 2, 2020
Member
oktomus
left a comment
oktomus
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution @laurelkeys.
Your PR looks pretty good, I just suggested some minor changes :)
dictoon
reviewed
Mar 2, 2020
oktomus
requested changes
Mar 3, 2020
oktomus
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1182.
Added thread index and number of threads as arguments to
on_tile_beginandhighlight_tile.From these values, one color can be uniquely selected per thread, using one of Inigo Quilez's color palettes.
(See https://www.shadertoy.com/view/wlKXDm for a demo)