Skip to content

Fix 5204 Use standard syntax for web code sample when loading the appwrite script #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spontaneouscombustion wants to merge 4 commits into from
Closed

Fix 5204 Use standard syntax for web code sample when loading the appwrite script #336

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d7fae1
Fix web code sample
spontaneouscombustion Mar 10, 2023
ba13279
Prevent svelte from processing the closing script tag
spontaneouscombustion Mar 14, 2023
de4efb7
fix build error
spontaneouscombustion Mar 15, 2023
13a5799
Merge branch 'appwrite:main' into fix-5204-use-standard-syntax-for-we…
spontaneouscombustion Mar 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/console/project-[project]/overview/platforms/wizard/web/step2.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

const example1 = `import { Client } from 'appwrite';`;
const example2 =
`<script src="https://cdn.jsdelivr.net/npm/appwrite@${$versions['client-web']}" />
`<script src="https://cdn.jsdelivr.net/npm/appwrite@${$versions['client-web']}"></script` + `>`
Copy link
Copy Markdown
Contributor

@stnguyen90 stnguyen90 Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem that's causing a build error. Please make sure the console builds successfully.

<script>
const { Client } = Appwrite;
</script` + `>`; // Prevent svelte from processing the closing script tag
Expand Down