-
Notifications
You must be signed in to change notification settings - Fork 182
fix: add unsupported attribute error #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8a92a46
to
312ba54
Compare
reason += compareAttribute(remote[key], local[key], reason, key) | ||
if (!recreating) { | ||
reason = compareAttribute(remote[key], local[key], reason, key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we want to concat so we keep all the reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are already concatenating the reasons here -
sdk-generator/templates/cli/lib/commands/push.js.twig
Lines 750 to 754 in a6bcc45
reason += `${bol}${key} changed from ${chalk.red(remote)} to ${chalk.green(local)}`; | |
} | |
} else if (!isEqual(remote, local)) { | |
const bol = reason === '' ? '' : '\n'; | |
reason += `${bol}${key} changed from ${chalk.red(remote)} to ${chalk.green(local)}`; |
concatenating here as well leads to double concat, as shown in the pr screenshot
What does this PR do?
min changed from -1.7976931348623157e+308 to -1.7976931348623157e+308
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.