Skip to content

fix: add unsupported attribute error #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 27, 2025

Conversation

ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented Jun 23, 2025

What does this PR do?

  1. fix unsupported attribute error.
  2. fix duplication of error messages:
    Screenshot 2025-06-23 at 8 35 37 AM
  3. fix strict comparision of floating points: min changed from -1.7976931348623157e+308 to -1.7976931348623157e+308

Test Plan

  1. Screenshot 2025-06-23 at 9 11 44 AM

  1. Screenshot 2025-06-23 at 9 12 04 AM

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

yes.

@ChiragAgg5k ChiragAgg5k force-pushed the fix-attribute-creation-errors branch from 8a92a46 to 312ba54 Compare June 23, 2025 04:01
@stnguyen90 stnguyen90 self-requested a review June 23, 2025 04:39
Comment on lines -756 to +787
reason += compareAttribute(remote[key], local[key], reason, key)
if (!recreating) {
reason = compareAttribute(remote[key], local[key], reason, key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to concat so we keep all the reasons?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are already concatenating the reasons here -

reason += `${bol}${key} changed from ${chalk.red(remote)} to ${chalk.green(local)}`;
}
} else if (!isEqual(remote, local)) {
const bol = reason === '' ? '' : '\n';
reason += `${bol}${key} changed from ${chalk.red(remote)} to ${chalk.green(local)}`;

concatenating here as well leads to double concat, as shown in the pr screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants