Fix typing exports for web SDK#653
Merged
lohanidamodar merged 1 commit intomasterfrom May 10, 2023
Merged
Conversation
For projects with moduleResolution set to bundler in tsconfig.json, the types must be exported in the package.json file.
stnguyen90
requested review from
Meldiron and
TorstenDittmann
and removed request for
Meldiron
TorstenDittmann
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For projects with moduleResolution set to bundler in tsconfig.json, the types must be exported in the package.json file.
Closes: appwrite/sdk-for-web#54
Test Plan
Manually added in a new project and I no longer see the error:
I also added it to another TS project of mine that has
moduleResolutionset tonodeand that still worked as expected:Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes