Skip to content

[NHC] Fix listen address behavior for 80 #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

banool
Copy link
Contributor

@banool banool commented Jun 30, 2022

Description

Turns out the url crate handles 80 differently (servo/rust-url#28), which meant the way I was dealing with ports wasn't correct. This PR fixes that.

Test Plan

cargo run --release -- server run --baseline-node-config-paths /tmp/eh.yaml --listen-address 0.0.0.0 --listen-port 80
curl localhost/get_configuration_keys

Previously this second command would fail.


This change is Reviewable

@banool banool enabled auto-merge (squash) June 30, 2022 19:57
@banool banool merged commit 7e12278 into main Jun 30, 2022
@banool banool deleted the banool/nhc_listen_address branch June 30, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants