feat(report): add end of service life flag to OS metadata#1142
Merged
knqyf263 merged 5 commits intoaquasecurity:mainfrom Jul 27, 2021
Merged
feat(report): add end of service life flag to OS metadata#1142knqyf263 merged 5 commits intoaquasecurity:mainfrom
knqyf263 merged 5 commits intoaquasecurity:mainfrom
Conversation
knqyf263
reviewed
Jul 22, 2021
pkg/scanner/scan.go
Outdated
| if eosl { | ||
| log.Logger.Warnf("This OS version is no longer supported by the distribution: %s %s", osFound.Family, osFound.Name) | ||
| log.Logger.Warnf("The vulnerability detection may be insufficient because security updates are not provided") | ||
| osFound.Eosl = eosl |
Collaborator
There was a problem hiding this comment.
We can put this line outside of this statement since this value should be filled regardless of the condition. I know the result will be the same since the default value of boolean is false, but the intent of the code is different.
knqyf263
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1118