Repository navigation
fix(python): resolve pylock.toml dependencies given by name only - #11459
Open
ozenyunus35 wants to merge 1 commit into
Open
ozenyunus35 wants to merge 1 commit into
ozenyunus35 wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
pylock.toml(PEP 751), an entry in[[packages.dependencies]]may give only aname, as long as that name picks a single package. Trivy always built the dependency ID fromnameandversion, so{ name = "beta" }turned intobeta@and matched nothing. The relationship was dropped, andbetashowed up directly underpylock.tomlin the SBOM.This follows the approach agreed in the issue:
versionworks as before.versionresolves to the package ID when exactly one package has that name.marker,vcs).I also bumped the analyzer version so cached results get re-analyzed.
Before, with the reproducer from the issue:
After:
The
pylock.tomlcomponent now depends only onalpha, instead of both. The parser test covers a unique name, an ambiguous one and an unknown one.Related issues
Checklist
I used an AI assistant to help draft parts of the code and tests; I reviewed the changes and ran the tests myself.