-
Notifications
You must be signed in to change notification settings - Fork 8
[Issue #75] Add support for field/case renames via flags #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a0fe697
initial work
arainko 0387185
actually exciting for once
arainko b9a6143
a nicer dsl is needed, or just pass stuff as explicit params? boooring
arainko e98bee7
use steps as opposed to segments
arainko 02fbb06
propagate flags everywhere in Planner, slightly refactor .get(_).map.…
arainko 0f205f4
POC impl of Defaults with flags
arainko 77b8e91
propagate priorities
arainko d8eeda5
fix compilation errors
arainko 5e8a8d7
add parser for defaults and nones, thread flags through to Planner
arainko 1f9b55b
rough poc of defaults for product to product only for now
arainko 5b973b1
take priority into consideration
arainko 8a77bc6
Revert "take priority into consideration"
arainko d1d3f8d
Revert "rough poc of defaults for product to product only for now"
arainko 6d3e266
remove Priority from Plan.Configured
arainko e6c9bb5
Revert "add parser for defaults and nones, thread flags through to Pl…
arainko 79bb4b7
actually, rebuilding defaults and nones as a flag is a godawful idea,…
arainko d3835e4
at long last - an actually working field renames POC
arainko bf56d41
crudely implemented coproduct renaming
arainko e7e4317
add local and typeSpecific modifiers
arainko 4604d07
e2e poc - implement Renamer parsing into a compiletime String => Stri…
arainko b0eb2d9
fix a small oopsie
arainko 1c2de3c
transfer Local flags to all the enum children (and children's childre…
arainko 9d12987
propagate flag span in ambiguity error messages
arainko ac51d52
add some very basic tests
arainko d796713
another set of tests
arainko 4ce083b
more test for local flags
arainko 19d3a59
fix handling of flags in BetweenFallibles and BetweenFallibleNonFalli…
arainko 421ca42
add tests for regional flags, finish up general flag tests
arainko d0b2890
finish up all tests
arainko 44127ae
apply feedback
arainko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
ducktape/src/main/scala/io/github/arainko/ducktape/Renamer.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package io.github.arainko.ducktape | ||
|
|
||
| sealed trait Renamer { | ||
| def toUpperCase: Renamer | ||
|
|
||
| def toLowerCase: Renamer | ||
|
|
||
| def rename(from: String, to: String): Renamer | ||
|
|
||
| def replace(target: String, replacement: String): Renamer | ||
|
|
||
| def regexReplace(pattern: String, replacement: String): Renamer | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.