Skip to content

[issue #319] use value.accessFieldByName instead of .accessFieldByNameUnsafe #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arainko merged 1 commit into from
Dec 29, 2025
Merged

[issue #319] use value.accessFieldByName instead of .accessFieldByNameUnsafe #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ducktape/src/main/scala/io/github/arainko/ducktape/internal/PlanInterpreter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ private[ducktape] object PlanInterpreter {
case Plan.BetweenProductTuple(source, dest, plans) =>
val args = plans.map {
case FieldPlan(fieldName: String, plan) =>
val fieldValue = value.accessFieldByNameUnsafe(fieldName).asExpr
val fieldValue = value.accessFieldByName(fieldName, source).asExpr
recurse(plan, fieldValue)
case FieldPlan(None, plan) =>
recurse(plan, value)
Expand Down
8 changes: 8 additions & 0 deletions scala-next-tests/src/test/scala/io/github/arainko/ducktape/NamedTupleSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,4 +356,12 @@ class NamedTupleSuite extends DucktapeSuite {
Field.allMatching(fieldSource)
)
}

test("named tuple to tuple works") {
assertTransforms((a = 1, b = 2, c = 3), (1, 2, 3))
}

test("tuple to named tuple works") {
assertTransforms((1, 2, 3), (a = 1, b = 2, c = 3))
}
}