GA-157 | Review #18
Merged
GA-157 | Review #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMahanna
commented
Aug 1, 2024
| for k, v in result.items(): | ||
| self.data[k] = self.__process_graph_dict_value(k, v) | ||
|
|
||
| def __process_graph_dict_value(self, key: str, value: Any) -> Any: |
There was a problem hiding this comment.
introduced this private method to process any value that would be added to GraphDict. Similar to process_graph_attr_dict_value, but without the concept of parent_keys and root
aMahanna
commented
Aug 1, 2024
| if value := self.data.get(key): | ||
| return value | ||
| assert self.graph_id |
There was a problem hiding this comment.
removing any need for graph_id assertions as you were able to make use of the factory method to set graph_id
aMahanna
commented
Aug 1, 2024
Comment on lines
-313
to
+314
| return result | ||
| return graph_attr_dict_value |
There was a problem hiding this comment.
returning the graph_attr_dict_value to maintain any remote connection (if result is of type dict)
aMahanna
commented
Aug 1, 2024
| @@ -359,7 +363,6 @@ def process_node_attr_dict_value(parent: NodeAttrDict, key: str, value: Any) -> | |||
|
|
|||
| node_attr_dict = parent.node_attr_dict_factory() | |||
| node_attr_dict.root = parent.root or parent | |||
| # TODO: Check if node_id can be passes by reference | |||
There was a problem hiding this comment.
turns out this is already the case, my bad:
a = "hello world"
b = a
print(id(a) == id(b))
hkernbach
approved these changes
Aug 2, 2024
aMahanna
added a commit
that referenced
this pull request
Aug 2, 2024
* moved tests, added root to G dict * all tests green * format, lint * fix a todo, fix flake * fix potential path that could be hit in case data structure is in unexpected state * use incr update instead * fixed missing parameter * added code suggestions, fixed update method in GraphDict which caused trouble * fix method signature * flake8 * do not clear remote data if clear() is being called * fmt * GA-157 | review (#18) --------- Co-authored-by: Anthony Mahanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.