Skip to content

[GA-153-0] Implement NodeDict update method #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 16, 2024
Merged

Conversation

hkernbach
Copy link
Member

@hkernbach hkernbach commented Aug 15, 2024

Replaces #12

@hkernbach hkernbach changed the title Feature/node dict [GA-153-0] Implement NodeDict update method Aug 15, 2024
@hkernbach hkernbach marked this pull request as ready for review August 15, 2024 11:49
Copy link
Member

@aMahanna aMahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just one small thing;

image

Can we add this update method in the CustomNodeView object? This will allow us to users the following:

G.nodes.update(...)

Instead of having to reference the _node object:

G._node.update(...)

Copy link
Member

@aMahanna aMahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things, looks good overall

@hkernbach
Copy link
Member Author

Looks good! just one small thing;

image

Can we add this update method in the CustomNodeView object? This will allow us to users the following:

G.nodes.update(...)

Instead of having to reference the _node object:

G._node.update(...)

Added in dce4e85

@hkernbach hkernbach requested a review from aMahanna August 16, 2024 09:53
@hkernbach hkernbach merged commit ea19c1f into main Aug 16, 2024
2 checks passed
@aMahanna aMahanna deleted the feature/node-dict branch August 28, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants