Skip to content

fix: cache nxcg graph instead of coo representation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Aug 15, 2024

Proposing to remove the following cached objects:

  • src_indices
  • dst_indices
  • edge_indices
  • vertex_ids_to_indices
  • edge_values

In favour of just caching the nxcg.Graph object that we create via the from_coo method.

Eventually we'll need to revisit this cache concept, because it immediately becomes out of date if a user modifies the NetworkX-ArangoDB Graph. For now, we can assume that the user will rely on G.clear_nxcg_cache to indicate that a new COO pull is required

Copy link
Member

@hkernbach hkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, minor comments left.

@aMahanna aMahanna merged commit 3913247 into main Aug 16, 2024
0 of 2 checks passed
@aMahanna aMahanna deleted the cache-nxcg-graph branch August 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants