nxadb_to_nx cleanup #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to revisit failing assertions ASAP
aMahanna
commented
Aug 16, 2024
| G_NX._node = node_dict | ||
|
|
||
| if isinstance(G_NX, nx.DiGraph): | ||
| G_NX._succ = G._adj = adj_dict["succ"] | ||
| G_NX._succ = G_NX._adj = adj_dict["succ"] |
There was a problem hiding this comment.
this was the bug culprit. I mistakenly overwrote the _adj of the nxadb.Graph object 😨
aMahanna
commented
Aug 16, 2024
Comment on lines
+140
to
+149
| # NOTE: At this point, we _could_ choose to implement something similar to | ||
| # NodeDict._fetch_all() and AdjListOuterDict._fetch_all() to iterate through | ||
| # **node_dict** and **adj_dict**, and establish the "custom" Dictionary classes | ||
| # that we've implemented in nx_arangodb.classes.dict. | ||
| # However, this would involve adding additional for-loops and would likely be | ||
| # slower than the current implementation. | ||
| # Perhaps we should consider adding a feature flag to allow users to choose | ||
| # between the two methods? e.g `build_remote_dicts=True/False` | ||
| # If True, then we would return the (updated) nxadb.Graph that was passed in. | ||
| # If False, then we would return the nx.Graph that is built below: |
There was a problem hiding this comment.
this would be an interesting point of discussion to address in a separate PR as an improvement
hkernbach
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nxadb_to_nxto return the easiest graph whenever possiblenxadb_to_nx(and re-addressestest_algorithmassertions because of this)