GA-163 | test_graph
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will fail
aMahanna
changed the title
aMahanna
changed the title
test_graph Test File
aMahanna
changed the title
test_graph Test Filetest_graph Test File
aMahanna
commented
Aug 20, 2024
Comment on lines
+1114
to
+1115
| # TODO: Revisit when DB-based subgraphing is supported | ||
| # class TestEdgeSubgraph: |
There was a problem hiding this comment.
just highlighting: skipping this entire suite right now because Subgraphing isn't really "officially" supported...
Merged
hkernbach
reviewed
Aug 23, 2024
Comment on lines
+641
to
+644
| if not (self.FETCHED_ALL_DATA or self.FETCHED_ALL_IDS): | ||
| self._fetch_all() | ||
|
|
||
| yield from self.data.keys() |
There was a problem hiding this comment.
This is good. Just as a global comment: At some point we should think about in general all tasks that could require some or long time to finish (e.g. loading a lot of edges, or loading huge edges, etc.) Some indicator for that would be great somewhen or visibility.
There was a problem hiding this comment.
ya good point. Something like a temporary spinner or a progress bar would be useful to have
There was a problem hiding this comment.
I've worked with these progress libraries before, could be something we can introduce:
hkernbach
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing https://github.com/networkx/networkx/blob/main/networkx/classes/tests/test_graph.py assertions for NetworkX-ArangoDB
Related to arangoml/phenolrs#32
Note that the following tests in
test_graph.pyare intentionally skipped for now:test_copy(reason: graph copying is not supported yet)test_class_copy(reason: graph copying is not supported yet)test_to_undirected(reason: graph copying is not supported yet)test_to_directed(reason: graph copying is not supported yet)test_subgraph(reason: subgraphing is not supported yet)test_pickle(reason: TBD)