GA-169 | rename graph_name to name
#38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMahanna
reviewed
Aug 20, 2024
aMahanna
changed the title
graph_name to name
aMahanna
previously approved these changes
Aug 20, 2024
aMahanna
changed the title
graph_name to namegraph_name to name
Co-authored-by: Anthony Mahanna <[email protected]>
|
Thinking about this again, we should make sure that the i.e this should not be possible: import nx_arangodb as nxadb
G = nxadb.Graph(name='myGraph')
G.add_node(...)
G.add_edge(...)
G.name = 'myNewGraph'
# or
G.graph["name"] = 'myNewGraph'This should be possible if we add an override for the setter method: https://github.com/networkx/networkx/blob/main/networkx/classes/graph.py#L400-L412 |
aMahanna
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.